pandas icon indicating copy to clipboard operation
pandas copied to clipboard
verified publisher icon pandas-dev

DEP: update python-calamine to 0.3.2

Open chilin0525 opened this issue 6 months ago • 3 comments

  • [x] closes https://github.com/pandas-dev/pandas/issues/61186
  • [ ] Tests added and passed if fixing a bug or adding a new feature
  • [ ] All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions.
  • [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This PR updates the calamine engine dependency to version 0.3.2, which includes the upstream fix for leading-zero truncation in VLOOKUP-derived Excel cells.

chilin0525 avatar Jun 08 '25 07:06 chilin0525

It'd be good to either link an existing issue, or to write a description, so we can understand why we should merge this.

datapythonista avatar Jun 09 '25 15:06 datapythonista

@datapythonista Thanks for the reminder! I’ve now added the issue link for clarity. Since this is my first PR involving a package version bump, I wanted to ask:

  1. Does the pandas community support this upgrade to calamine >= 0.3.2? If it’s not aligned with project goals, I’m happy to close the PR.
  2. If the upgrade is approved, would you like me to add a unit test covering the original issue scenario?

Thanks!

chilin0525 avatar Jun 10 '25 17:06 chilin0525

Thanks for the context. This looks reasonable. In general we support dependencies that are two years old. Given there is a bug, I guess it can make sense to require a version that is newer than that. @mroeschke @rhshadrach do you have an opinion on whether it's more important to be compatible with older versions one of the libraries to read Excel, or to prevent a bug it has?

datapythonista avatar Jun 10 '25 17:06 datapythonista

Given there is a bug, I guess it can make sense to require a version that is newer than [2 years]. ... do you have an opinion on whether it's more important to be compatible with older versions one of the libraries to read Excel, or to prevent a bug it has?

Every optional dependency has bugfixes on just about every release, I think a bugfix would only justify bumping the minimum version if it is of an serious nature. Security issues as well. I do not think this is the case here.

rhshadrach avatar Jun 19 '25 20:06 rhshadrach

Let's close this then. I assume many users create a fresh environment and they'll get a new version anyway. For the people who has environments with the old dependency, hopefully they can find information that leads them to upgrading the buggy version.

datapythonista avatar Jun 19 '25 20:06 datapythonista