pandas icon indicating copy to clipboard operation
pandas copied to clipboard

BUG: Copy attrs on pd.merge()

Open timhoffm opened this issue 1 year ago • 3 comments

This uses the same logic as pd.concat(): Copy attrs only if all input attrs are identical.

I've refactored the handling in finalize from special-casing based on th the method name (previously only "concat") to handling "other" parameters that have an input_objs attribute. This is a more scalable architecture compared to hard-coding method names in finalize.

Tests added for concat() and merge().

Closes #60351.

timhoffm avatar Nov 19 '24 00:11 timhoffm

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

github-actions[bot] avatar Dec 20 '24 00:12 github-actions[bot]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

I'm still interested in this, and IMHO it's ready for review.

timhoffm avatar Dec 30 '24 10:12 timhoffm

Sorry @timhoffm nobody reviewed this. We don't have many people reviewing nowadays, and some PRs are never reviewed. Do you mind updating your branch and adding a release note? I'll try to have a look at this soon.

@rhshadrach I think you checked this already when discussed in the issue. If you have time to have a look at the implementation, that would be great.

datapythonista avatar Jun 02 '25 21:06 datapythonista

Thanks for sticking with this @timhoffm

mroeschke avatar Jun 30 '25 18:06 mroeschke