pandas icon indicating copy to clipboard operation
pandas copied to clipboard

Fix : #58748 BUG: eval fails for ExtensionArray

Open SiddheshBangar opened this issue 1 year ago • 3 comments

  • [x] closes #58748 (Replace xxxx with the GitHub issue number)
  • [x] Tests added and passed if fixing a bug or adding a new feature
  • [x] All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions.
  • [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

SiddheshBangar avatar May 19 '24 23:05 SiddheshBangar

Hey @mutricyl thanks for mentioning it, I have worked on it and did the necessary changes. Let me know if any other changes need to be made I will work on it. Thanks

SiddheshBangar avatar May 21 '24 01:05 SiddheshBangar

Thanks @rhshadrach @mutricyl I will work on this and update the PR as well

SiddheshBangar avatar May 22 '24 01:05 SiddheshBangar

Although, I tried making necessary changes, and I run the pre-commits as well didn't faced any issues in it but while doing here some checks are failing any guidance how can I move forward to this?

SiddheshBangar avatar May 22 '24 14:05 SiddheshBangar

@rhshadrach @mutricyl pushed one more PR, I fixed the issues, sorry from my end once again. Let me know if this works perfectly. Once again thanks for the help.

SiddheshBangar avatar May 28 '24 19:05 SiddheshBangar

Hey @rhshadrach @mutricyl just a follow up message that could you check the PR that I have pushed a while ago I hope this works for your guys do check and let me know if any more changes are required to be done from my end as well. Thanks!

SiddheshBangar avatar Jun 03 '24 18:06 SiddheshBangar

@rhshadrach updated the docs and committed the changes do check the PR and let me know if this works, Thanks!

SiddheshBangar avatar Jun 09 '24 11:06 SiddheshBangar

Thanks @SiddheshBangar

rhshadrach avatar Jun 12 '24 21:06 rhshadrach

Welcome, thanks for helping and the guidance @rhshadrach, @mutricyl

SiddheshBangar avatar Jun 13 '24 19:06 SiddheshBangar