pandas icon indicating copy to clipboard operation
pandas copied to clipboard

DEPR: Change stacklevel to 2 in DataFrame(mgr) deprecation

Open Aloqeely opened this issue 1 year ago • 4 comments

For reference: #55591

@jorisvandenbossche is this the only thing I'm supposed to change? or am I supposed to also change all stacklevel=2 to stacklevel=find_stack_level()

Aloqeely avatar May 13 '24 07:05 Aloqeely

is this the only thing I'm supposed to change? or am I supposed to also change all stacklevel=2 to stacklevel=find_stack_level()

This should be sufficient, and we explicitly want to keep it hard-coded at 2 and not use find_stack_level() for this case.

jorisvandenbossche avatar May 14 '24 12:05 jorisvandenbossche

And thanks for the PR! If you merge in latest main, that should fix some of the CI failures.

jorisvandenbossche avatar May 14 '24 12:05 jorisvandenbossche

And thanks for the PR! If you merge in latest main, that should fix some of the CI failures.

My pleasure - green now.

Aloqeely avatar May 14 '24 19:05 Aloqeely

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

github-actions[bot] avatar Jun 22 '24 00:06 github-actions[bot]

Thanks @Aloqeely!

jorisvandenbossche avatar Oct 30 '24 08:10 jorisvandenbossche