pandas icon indicating copy to clipboard operation
pandas copied to clipboard

DOC: Enforce Numpy Docstring Validation | pandas.api.extensions.ExtensionArray

Open gboeker opened this issue 9 months ago • 4 comments

DOC: Enforce Numpy Docstring Validation (Parent Issue) #58063

Pandas has a script for validating docstrings in code_checks.sh. Currently, some methods fail some of these checks.

pandas.api.extensions.ExtensionArray

https://github.com/pandas-dev/pandas/blob/c468028f5c2398c04d355cef7a8b6a3952620de2/ci/code_checks.sh#L590-L620

The task is:

  1. take 1-5 methods

  2. run: scripts/validate_docstrings.py --format=actions <method-name>

example command: scripts/validate_docstrings.py --format=actions pandas.Categorical.__array__ example output:

################################################################################
################################## Validation ##################################
################################################################################

2 Errors found for `pandas.Categorical.__array__`:
	ES01	No extended summary found
	SA01	See Also section not found
  1. check if validation docstrings passes for those methods, and if it’s necessary fix the docstrings according to whatever error is reported. Note: We've chosen to ignore ES01 errors, these are not required to be fixed.

  2. remove those methods from code_checks.sh if all errors are cleared and the docstring is correct, otherwise, remove the specific error that was fixed from the list of errors for that method.

  3. commit, push, open pull request

Please don't comment take as multiple people can work on this issue. You also don't need to ask for permission to work on this, just comment on which methods are you going to work : )

If you're new contributor, please check the contributing guide

thanks @datapythonista @jordan-d-murphy for the inspiration for this issue!

gboeker avatar May 02 '24 20:05 gboeker

take

 -i "pandas.api.extensions.ExtensionArray SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._accumulate RT03,SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._concat_same_type PR07,SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._formatter SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._from_sequence SA01" \ 

gboeker avatar May 02 '24 21:05 gboeker

working on

 -i "pandas.api.extensions.register_extension_dtype SA01" \ 

tuhinsharma121 avatar May 07 '24 11:05 tuhinsharma121

Take:

        -i "pandas.api.extensions.ExtensionArray.isna SA01" \
        -i "pandas.api.extensions.ExtensionArray.nbytes SA01" \
        -i "pandas.api.extensions.ExtensionArray.ndim SA01" \
        -i "pandas.api.extensions.ExtensionArray.ravel RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.take RT03" \

abhinav-thimma avatar Aug 17 '24 15:08 abhinav-thimma

Take:

        -i "pandas.api.extensions.ExtensionArray.duplicated RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.fillna SA01" \
        -i "pandas.api.extensions.ExtensionArray.insert PR07,RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.isin PR07,RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.tolist RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.unique RT03,SA01" \
        -i "pandas.api.extensions.ExtensionArray.view SA01" \

abhinav-thimma avatar Aug 25 '24 22:08 abhinav-thimma

Worked on pandas.api.extensions.ExtensionArray.interpolate PR01,SA01

ammar-qazi avatar Sep 08 '24 04:09 ammar-qazi