pandas icon indicating copy to clipboard operation
pandas copied to clipboard

DOC: fix PR07 errors in docstrings

Open jordan-d-murphy opened this issue 1 year ago • 2 comments

Pandas has a script for validating docstrings:

Currently, some methods fail the PR07 check.

https://github.com/pandas-dev/pandas/blob/5fff2cd4818514a2d217e4202e1d78de2290c207/ci/code_checks.sh#L144-L258

The task here is:

  • take 2-4 methods
  • run: scripts/validate_docstrings.py --format=actions --errors=PR07 method-name
  • check if validation docstrings passes for those methods, and if it’s necessary fix the docstrings according to whatever error is reported
  • remove those methods from code_checks.sh
  • commit, push, open pull request

Please don't comment take as multiple people can work on this issue. You also don't need to ask for permission to work on this, just comment on which methods are you going to work.

If you're new contributor, please check the contributing guide

jordan-d-murphy avatar Feb 14 '24 17:02 jordan-d-murphy

I don't have permission to add them, but this could probably use some labels:

  • CI
  • Docs
  • good first issue

jordan-d-murphy avatar Feb 14 '24 17:02 jordan-d-murphy

Addresses https://github.com/pandas-dev/pandas/pull/57357

jordan-d-murphy avatar Feb 14 '24 17:02 jordan-d-murphy

opened a fix for pandas.DataFrame.align

jordan-d-murphy avatar Feb 25 '24 08:02 jordan-d-murphy

opening a fix for

pandas.DataFrame.get
pandas.DataFrame.rolling
pandas.DataFrame.to_hdf

jordan-d-murphy avatar Mar 10 '24 22:03 jordan-d-murphy

Hi all, if CI: speedup docstring check consecutive runs #57826 gets merged in, I might be reworking our approach here; this would look like closing the following issues:

DOC: fix GL08 errors in docstrings DOC: fix PR01 errors in docstrings DOC: fix PR07 errors in docstrings DOC: fix SA01 errors in docstrings DOC: fix RT03 errors in docstrings DOC: fix PR02 errors in docstrings

And opening a new issue to address these based on the new approach.

tl;dr

the work can still be done, but probably under a new ticket once #57826 is merged in

jordan-d-murphy avatar Mar 17 '24 00:03 jordan-d-murphy

Opened DOC: Enforce Numpy Docstring Validation (Parent Issue) #58063 as a parent issue for fixing docstrings based on the refactoring in code_checks.sh

Feel free to swing by and help out! 🙂

jordan-d-murphy avatar Mar 29 '24 06:03 jordan-d-murphy