pandas icon indicating copy to clipboard operation
pandas copied to clipboard

DEPR: object inference in to_stata

Open jbrockmendel opened this issue 2 years ago • 3 comments

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tests added and passed if fixing a bug or adding a new feature
  • [ ] All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions.
  • [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The "do X instead" won't actually work until 3.0, so this has to wait until then (and can't write the whatsnew until the 3.0 file exists). Putting this here so I don't forget about it.

jbrockmendel avatar Dec 17 '23 18:12 jbrockmendel

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

github-actions[bot] avatar Jan 18 '24 00:01 github-actions[bot]

Now that we have the 3.0.0.rst file now, interested in following up?

mroeschke avatar Apr 01 '24 18:04 mroeschke

Going to hold off until #55901 goes in

jbrockmendel avatar Apr 01 '24 20:04 jbrockmendel

it looks like we don't have any test cases that get to the relevant path. editing test_big_dates to use expected.astype(object).to_stata fails pretty badly; it looks like in the delta=True case by storing microseconds instead of milliseconds.

two options: first is to change the relevant path to call infer_objects() and then recurse, second is to just rip out the now-identified-as-buggy path. preferences?

jbrockmendel avatar Jun 01 '24 03:06 jbrockmendel

Probably just take it out. Simplicity is its own reward.

bashtage avatar Jun 13 '24 17:06 bashtage