panda icon indicating copy to clipboard operation
panda copied to clipboard

Shall the workaround for llvm.11089 be removed?

Open Chandlerooo opened this issue 2 years ago • 0 comments

I notice several workarounds for llvm.11089: https://github.com/panda-re/panda/blob/d2ee3d1bde15623813bcae1708eaa7d759cedd96/panda/tools/helper_call_modifier.cpp

/* * XXX: We need to remove stack smash protection from helper * functions that are to be compiled with the JIT. There is a bug * in LLVM 3.0 that causes the JIT to generate stack protection code * that causes the program to segfault. More information available * here: http://llvm.org/bugs/show_bug.cgi?id=11089 */ const AttributeList AS = newFunc->getAttributes(); newFunc->setAttributes(AS.removeAttribute(newFunc->getContext(), AttributeList::FunctionIndex, Attribute::StackProtectReq));

This compiler bug is already marked as fixed: https://bugs.llvm.org/show_bug.cgi?id=11089

Shall the above workaround be removed?

Chandlerooo avatar Jul 04 '22 16:07 Chandlerooo