panda icon indicating copy to clipboard operation
panda copied to clipboard

Published 20 hours ago • verified publisher icon panda-re

Unnecessary memcb enabling

Open lacraig2 opened this issue 3 years ago • 0 comments

Two plugins call panda_enable_memcb without registering memory based callbacks.

  • callstack_instr: https://github.com/panda-re/panda/blob/98d0b10956d761aa455c68ad7b1cf422e756599f/panda/plugins/callstack_instr/callstack_instr.cpp#L566
  • pri_dwarf: https://github.com/panda-re/panda/blob/98d0b10956d761aa455c68ad7b1cf422e756599f/panda/plugins/pri_dwarf/pri_dwarf.cpp#L2440

In the case of pri_dwarf there seem to be callbacks that are no longer there. For callstack_instr I have no justification.

It seems unnecessary for both.

lacraig2 avatar Jan 06 '22 03:01 lacraig2