pancake-frontend icon indicating copy to clipboard operation
pancake-frontend copied to clipboard

[BUG] WalletConnect Issue

Open divyangkhatri opened this issue 10 months ago • 6 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Product

Trade

Current Behavior

We are in the process of integrating our wallet application with your PancakeSwap platform via WalletConnect. During this integration, we have encountered an additional method, wallet_addEthereumChain. Currently, we are passing the chainId as a parameter in the request (request?.params?.[0]?.chainId). However, we have observed that this approach yields inconsistent results - it works intermittently.

Expected Behavior

I think wallet_addEthereumChain is only for metamask connection. This method doesn't require for connection type walletconnect. So, I think method should be remove when connection type is wallet connect.

Steps To Reproduce

Try to do walletconnect from wallet app locally and observed the SESSION_REQUEST event

Environment

- Device: Macbook Pro
- OS: Mac OS 14.2.1
- Browser: Chrome
- Wallet: WalletConnect combatible wallet (need to check locally to observe the event)

Anything else?

No response

divyangkhatri avatar Apr 24 '24 10:04 divyangkhatri