pancake-frontend icon indicating copy to clipboard operation
pancake-frontend copied to clipboard

fix: Token warning not appear when accessing from url and cannot be dismissed

Open memoyil opened this issue 1 year ago • 6 comments


PR-Codex overview

This PR updates components in the Swap feature:

  • Refactors BottomDrawer and PriceChartContainer
  • Adds a custom dismiss function in SwapWarningModal
  • Enhances warning handling in Swap view

Detailed summary

  • Updated BottomDrawer and PriceChartContainer in Swap
  • Added custom dismiss function in SwapWarningModal
  • Improved warning handling in Swap view

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

memoyil avatar Feb 28 '24 17:02 memoyil

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am
web ❌ Failed (Inspect) Jun 4, 2024 7:13am

vercel[bot] avatar Feb 28 '24 17:02 vercel[bot]

⚠️ No Changeset found

Latest commit: 83617762705cba19302b1e1512122c508ac4208f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 28 '24 17:02 changeset-bot[bot]

Typescript errors check

Yeah, you have removed 2 errors with this PR 👏

876 ts errors detected in all the codebase 😟.

Well done: no ts errors in files changed in this PR! 🎉

chefjackson/action-check-typescript

github-actions[bot] avatar Feb 28 '24 17:02 github-actions[bot]

@memoyil could you help take a look at the rest ts errors?

chefjackson avatar Mar 01 '24 04:03 chefjackson

@memoyil could you help take a look at the rest ts errors?

Done

memoyil avatar Mar 01 '24 08:03 memoyil

@memoyil fyi will push back merging this pull request to prevent possible merge conflict for universal router

chefjackson avatar Mar 06 '24 02:03 chefjackson