pancake-frontend icon indicating copy to clipboard operation
pancake-frontend copied to clipboard

[Feature Request] Add Zeal as a supported wallet

Open Nicvaniek opened this issue 1 year ago • 12 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Is your feature request related to a problem you are facing?

Many Zeal wallet users use pancake swap and are having difficulties connecting due to having to select the "Injected" option. Clicking on Metamask like on other dApps does not work in this case (I have not dug very deep into the code, but assuming there is a different connector in use).

Describe the solution you'd like

Would be nice if there was a dedicated Zeal option (similar to Rabby) that users can select if Zeal is installed. I have tested the change locally and it works fine, but wanted to create this issue before making a PR in case anyone wants to discuss the proposal. I would probably also need assistance to get the Zeal icon added to the CDN?

How does this feature benefit PancakeSwap users and CAKE holders?

If they use Zeal wallet, they will have a much improved UX when using pancake swap. Their wallet of choice will show up as a first-class citizen when interacting with the UI.

Anything else?

image image

Nicvaniek avatar Jan 02 '24 13:01 Nicvaniek

Seems like I don't have permissions to push a new branch, so help from someone here would be appreciated. Below is the code snippet to be added to apps/web/src/config/wallet.ts:

{
      id: 'zeal',
      title: 'Zeal',
      icon: `${ASSET_CDN}/web/wallets/zeal.png`,
      get installed() {
        return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal)
      },
      connectorId: ConnectorNames.Injected,
      guide: {
        desktop: 'https://docs.zeal.app/getting-started-with-zeal',
      },
      downloadLink: {
        desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj',
      },
},

Where zeal.png is the below image:

Zeal_Logo

Nicvaniek avatar Jan 02 '24 17:01 Nicvaniek

@chef-jojo

Nicvaniek avatar Jan 05 '24 11:01 Nicvaniek

Hi @Nicvaniek just wanted to know, is it possible to encrypt or decrypt data using passkeys when using webauthn APIs, if yes, can you suggest how it can be done.

Surya-Git-hub avatar Jan 11 '24 18:01 Surya-Git-hub

{ id: 'zeal', title: 'Zeal', icon: ${ASSET_CDN}/web/wallets/zeal.png, get installed() { return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal) }, connectorId: ConnectorNames.Injected, guide: { desktop: 'https://docs.zeal.app/getting-started-with-zeal', }, downloadLink: { desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj', }, },

Hitosaw avatar Jan 13 '24 05:01 Hitosaw

{ id: 'zeal', title: 'Zeal', icon: ${ASSET_CDN}/web/wallets/zeal.png, get installed() { return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal) }, connectorId: ConnectorNames.Injected, guide: { desktop: 'https://docs.zeal.app/getting-started-with-zeal', }, downloadLink: { desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj', }, },

Hitosaw avatar Jan 13 '24 05:01 Hitosaw

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Feb 13 '24 01:02 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Mar 15 '24 01:03 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Apr 14 '24 01:04 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar May 15 '24 01:05 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Jun 14 '24 01:06 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Jul 14 '24 01:07 PancakeSwap-bot

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

PancakeSwap-bot avatar Aug 16 '24 01:08 PancakeSwap-bot