pancake-frontend icon indicating copy to clipboard operation
pancake-frontend copied to clipboard

feat: onramp regional ip block (FE integration)

Open ChefBingbong opened this issue 1 year ago • 5 comments


PR-Codex overview

This PR focuses on improving the BuyCrypto feature.

Detailed summary

  • Added ProviderAvailabilities type to types.ts.
  • Added parseDisabledProviders function to constants.ts.
  • Updated fetchMercuryoSignedUrl function in useIframeUrlFetcher.ts.
  • Removed setUsersIpAddress action in actions.ts.
  • Updated BuyCryptoPage component in index.tsx.
  • Updated GetQuotesButton component in GetQuotesButton.tsx.
  • Removed userIpAddress from BuyCryptoState in reducer.ts.
  • Updated ProviderCampaign component in ProviderCampaign.tsx.
  • Updated fetchProviderAvailabilities function in useProviderAvailability.ts.
  • Updated CryptoQuoteForm component in CryptoQuoteForm.tsx.
  • Updated Accordion component in Accordion.tsx.
  • Updated BuyCrypto component in index.tsx.
  • Updated useBuyCryptoActionHandlers and usePriceQuotes hooks in hooks.ts.

The following files were skipped due to too many changes: apps/web/src/state/buyCrypto/hooks.ts, apps/web/src/views/BuyCrypto/containers/BuyCryptoForm.tsx, apps/web/src/views/BuyCrypto/hooks/usePriceQuoter.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}


PR-Codex overview

Focus of the PR:

The focus of this PR is to remove the check for disabled providers in the sortProviderQuotes function in the usePriceQuoter hook.

Detailed summary:

  • Removed the check for disabled providers in the sortProviderQuotes function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

ChefBingbong avatar Dec 23 '23 05:12 ChefBingbong

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:42am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:42am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 11:42am
blog ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 11:42am
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 11:42am
uikit ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 11:42am

vercel[bot] avatar Dec 23 '23 05:12 vercel[bot]

⚠️ No Changeset found

Latest commit: c92ea0393c0f90f49abee93d09d81ff1b05a583a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 23 '23 05:12 changeset-bot[bot]

Typescript errors check

Yeah, you have removed 1 errors with this PR 👏

1754 ts errors detected in all the codebase 😟.

Well done: no ts errors in files changed in this PR! 🎉

chefjackson/action-check-typescript

github-actions[bot] avatar Dec 23 '23 05:12 github-actions[bot]

Any reason not using middleware?

0xjojoex avatar Dec 24 '23 05:12 0xjojoex

Any reason not using middleware?

do u mean for getting the ip?

ChefBingbong avatar Dec 24 '23 08:12 ChefBingbong