pancake-frontend icon indicating copy to clipboard operation
pancake-frontend copied to clipboard

fix: (prediction): Markascollected action makes epoch claimable again

Open memoyil opened this issue 2 years ago • 2 comments

To reproduce:

  1. Go to prediction
  2. Click collect winnings
  3. After the collection collect winnings appears again until the next fetch

memoyil avatar Aug 31 '22 12:08 memoyil

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 10:55am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Apr 4, 2023 10:55am
blog ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2023 10:55am
bridge ⬜️ Ignored (Inspect) Apr 4, 2023 10:55am
og-image ⬜️ Ignored (Inspect) Apr 4, 2023 10:55am
uikit ⬜️ Ignored (Inspect) Apr 4, 2023 10:55am

vercel[bot] avatar Aug 31 '22 12:08 vercel[bot]

⚠️ No Changeset found

Latest commit: a3e3bcb0a6263bc5f1430fbdfd46df372e53982f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 25 '22 08:10 changeset-bot[bot]

Do you know why it marks true in the first place?

chefilip avatar Nov 15 '22 13:11 chefilip

Do you know why it marks true in the first place?

Redux action was different at that time (f2c2affc1323880b707a67d81ef6082eef15f758), it was using true to mark as collected but now we should mark it false (claimableStatus object is {[epoch]: claimable}) to not get them in claimableStatuses selector

memoyil avatar Nov 15 '22 13:11 memoyil

@memoyil is attempting to deploy a commit to the PancakeSwap Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 11 '23 16:01 vercel[bot]