panbingkun

Results 88 comments of panbingkun

> So we make a breaking change simply because we don't like the object address in the string? can we fix it? - These types cannot be read back through...

> `to_json` should be fine because it has nested type representation Yeah, there is no standard for nested types in `csv` format, but the `json` format has a standard.

- Why is the result displayed through `to_csv` inconsistency in Scala and Python for this case? Because this case is on the `python side`, it ultimately uses `GenericArrayData`, which happens...

Use `ToPrettyString.eval` to generate pretty strings for these types in `to_csv`, I have also tried it in this PR. Below: https://github.com/apache/spark/pull/44665/commits/22a7afb6951b9274cc428f71e675df233de74a8a (PS: Maybe some details about `using ToPrettyString.eval` still need...

> The below MR may give some hints also to this ticket, bumping Jersey to v3.1.x requires all Spark to comply with EE10 standards, as I have tried during the...

- According to @gengliangwang's suggestion, we did not migrate the `test` code in the `structured log`, so we need to exclude them, eg: - Other exclusion is: `common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java` A.the module...

> I am +1 for the idea. However, I wonder if there will be suggestions about why the two imports are not allowed and how to fix the style error....

sh dev/lint-java ``` Using `mvn` from path: /Users/panbingkun/Developer/infra/maven/maven/bin/mvn -e Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:[33] (regexp) RegexpSinglelineJava: Please use org.apache.spark.internal.(Logger|LoggerFactory) instead. [ERROR] src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:[34] (regexp) RegexpSinglelineJava: Please use org.apache.spark.internal.(Logger|LoggerFactory)...

> Or how about having these modules depend on the `common/utils` module? `common/utils` doesn't seem to be a heavyweight module, in this way, the existing cases can be fixed. Done.

Ready for it, @gengliangwang @dongjoon-hyun @LuciferYang