Pierre Leroux comments

Results 198 comments of


                                            Pierre Leroux

[new GUI] regression: TTS captions mode is broken (nothing happens when I tick the checkbox)

When i tick the checkbox `set_config` is dispatched : ```{ type: 'READER_SET_CONFIG_IN_RENDERER', payload: { align: 'auto', colCount: '2', dark: false, font: 'OLD', fontSize: '100%', invert: false, lineHeight: '0', night: false,...

No error messages in LCP renew toast notification just a json status printed

https://readium.org/lcp-specs/releases/lsd/latest#31-handling-errors

No error messages in LCP renew toast notification just a json status printed

https://github.com/edrlab/thorium-reader/blob/1917addafad34c58bbe1a26ff6cff08a089002e2/src/main/services/lcp.ts#L1141-L1176

No error messages in LCP renew toast notification just a json status printed

I will check

Chromium bug: long HTML tables that span across column boundaries (paginated mode) => "break" row position but also causes offset of client rectangles coordinates (affects TTS, annotation highlights, search, etc.)

tested and works in chrome 126

keyboard focus outline is barely visible with some GUI controls

seems fixed : I'm closing

Software update version check

https://www.electronjs.org/fr/docs/latest/api/process#processwindowsstore-readonly :) clever !

tab keyboard is completely stuck in docked TOC (not in settings docked)

seems fixed by #2143

tab keyboard is completely stuck in docked TOC (not in settings docked)

fixed by #2143

fix(2144): setLocator is called once by the navigator at startup and

see comment of Daniel : https://github.com/edrlab/thorium-reader/issues/2144#issuecomment-2096486428