paloma icon indicating copy to clipboard operation
paloma copied to clipboard

Published 20 hours ago • verified publisher icon palomachain

CURIOSITY ONLY: Add codeql-analyzer to CI

Open measure-fi opened this issue 2 years ago • 4 comments

https://github.com/palomachain/paloma/issues/526

I'm just curious.

measure-fi avatar Oct 05 '22 19:10 measure-fi

I love curiosity! Let's be curious!

taariq avatar Oct 05 '22 19:10 taariq

Closing for now.

taariq avatar Oct 11 '22 16:10 taariq

@taariq One of these errors did line up with the fixes last week. I think the payoff here is rather large: it avoids a chain halt. I'd budget 1.5 days of my time to fix all of these and then leave it on in CI to audit future work. When exactly that happens is a matter of prioritization, but it should happen.

measure-fi avatar Oct 11 '22 17:10 measure-fi

@measure-fi re-opening!

taariq avatar Oct 11 '22 18:10 taariq

I think the floating point error is actually bad, so I'm leaving it in for now. Will need more thought on that one.

measure-fi avatar Oct 18 '22 20:10 measure-fi