express-ping icon indicating copy to clipboard operation
express-ping copied to clipboard

Published 20 hours ago • verified publisher icon palmerabollo

test: expect 200 status

Open henriklundgren opened this issue 7 years ago • 2 comments

It fails on Jest unfortunately, the reason is https://github.com/facebook/jest/issues/2150. I dont know if the best course of action is to wait and see if Jest updates, or if other test framework also fails then maybe write a different implementation.

henriklundgren avatar Jun 30 '17 10:06 henriklundgren

@henriklundgren, thanks for your first contribution. The issue has something to do with the way we look for the main package.json file.

Do you know if that part could be implemented in a different way?

palmerabollo avatar Jun 30 '17 11:06 palmerabollo

I guess just use https://github.com/sindresorhus/pkg-dir. But I dont have time to investigate the effectiveness of the change, i.e. all the use cases.

Edit: I was too quick there wasnt I, but the idea still holds. I will update and get it hopefully right.

henriklundgren avatar Jun 30 '17 11:06 henriklundgren