Guido García

Results 80 comments of Guido García
trafficstars

@jessecooper I think we should reopen this issue since 2.0.0 (final) doesn't work either. We are stuck to 2.0.0rc6

Agree. This change breaks backwards compatibility, though.

@alexclownfish what is the expected behaviour you'd like? Do you propose that we remove these two logs?

@rmadamson do you feel like contributing this change to the repo?

SASL was added by an external contributor in #46. I've not tried it myself, so I can't help a lot. However, @vishal14101986-git there is an unmerged pull requests that might...

Not sure about it. Were you able to fix the issue @PDelVal? Could you please try with the latest 1.9.0 version?

Hi @jerryum, that's a big message. I think it has nothing to do with prometheus-kafka-adapter, but with Kafka config itself. Could you try to increase the `message.max.bytes` in your Kafka...

@ivolo, do tests pass for you? After cloning the project, installing "expresso", and adding "express" and "should" to the dev dependencies, I run "make test" and I get many errors...

BTW you can see the changes I propose here https://github.com/palmerabollo/express-rate/compare/feature;memory_ttl?expand=1 , but I'd like to test it a bit more and make your tests pass.