werkzeug icon indicating copy to clipboard operation
werkzeug copied to clipboard

Switch to an event allowlist for watchdog

Open lociii opened this issue 1 year ago • 1 comments

Ignores the new closed_no_write event type fired by watchdog 5.x that is causing unnecessary reloads.
To prevent such cases in the future, I introduced an event allow list.

fixes https://github.com/pallets/werkzeug/issues/2945

  • Test case added
  • Change log added

lociii avatar Sep 05 '24 09:09 lociii

Can we please get a little speed on this one?
werkzeug is currently broken when using it with django-extensions and not pinning watchdog to a 4.x release.

https://github.com/pallets/werkzeug/issues/2945#issuecomment-2354842482

lociii avatar Sep 23 '24 08:09 lociii

I had to rebase to change the target from main to stable. Since you opened this PR from your main branch, you'll need to reset it: git fetch upstream && git reset --hard upstream/main. Remember to create pull requests from dedicated branches.

davidism avatar Oct 24 '24 22:10 davidism