quart icon indicating copy to clipboard operation
quart copied to clipboard

Base Quart's default_config on Flask's

Open JamesParrott opened this issue 1 year ago • 1 comments

Fixes #371 without pinning Flask to 3.0.0

  • [x ] Run pre-commit hooks and fix any issues.

A three line change, as per the title:

image

JamesParrott avatar Nov 14 '24 12:11 JamesParrott

Thanks for the review. I've made the first change to the import. I case sensitive searched for "Flask" and that string only shows up in comments, so from this basic search at least, I couldn't find a clash in the namespace, so I assume the addition to the namespace is fine.

I don't object to cleaning up the keys, but I'd prefer if someone else took that job on. The first time I looked at Quart's source code was Tuesday this week, so I don't yet have enough knowledge of Flask and Quart to say what all the config items do, and which can safely be removed.

JamesParrott avatar Nov 15 '24 13:11 JamesParrott