flask-session icon indicating copy to clipboard operation
flask-session copied to clipboard

implement PostgreSQL sessions

Open giuppep opened this issue 10 months ago • 5 comments

Integrating flask-pg-session into flask-session.

To do:

  • [x] tests
  • [x] documentation

giuppep avatar Mar 28 '24 18:03 giuppep

What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?

Lxstr avatar Mar 29 '24 02:03 Lxstr

What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?

Yeah, makes sense, will implement it like this. I just don't think it should be optional as there is no way to guess the URI of the database (even if we assume the db is on localhost, you still need to specify the db name).

giuppep avatar Apr 03 '24 12:04 giuppep

Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me

Lxstr avatar Apr 09 '24 08:04 Lxstr

Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me

Should be fixed now 👍🏽

giuppep avatar Apr 16 '24 11:04 giuppep

Has been merged into dev

Lxstr avatar Apr 18 '24 06:04 Lxstr