flask-session
flask-session copied to clipboard
implement PostgreSQL sessions
What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?
What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?
Yeah, makes sense, will implement it like this. I just don't think it should be optional as there is no way to guess the URI of the database (even if we assume the db is on localhost, you still need to specify the db name).
Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me
Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me
Should be fixed now 👍🏽
Has been merged into dev