isolator icon indicating copy to clipboard operation
isolator copied to clipboard

add vcr adapter

Open kehra opened this issue 1 year ago • 2 comments

What is the purpose of this pull request?

When testing with VCR, I want to check if HTTP requests are being made.

What changes did you make? (overview)

Add an adapter for VCR

Checklist

  • [x] I've added tests for this change
  • [x] I've added a Changelog entry
  • [x] I've updated a documentation

kehra avatar Aug 30 '24 01:08 kehra

Thanks for the PR, but from the failing tests it looks like it's already been caught by Sniffer, no specific handling of VCR required. Could you check please?

palkan avatar Sep 17 '24 00:09 palkan

Thank you for confirming. I'll check this when I have free time later.

As you say, the VCR uses other libraries, so it may not be necessary 🤔

kehra avatar Sep 23 '24 01:09 kehra

I close this because I have found that it is not necessary. Thank you for your advice.

kehra avatar Nov 02 '24 08:11 kehra