nm-tray icon indicating copy to clipboard operation
nm-tray copied to clipboard

Add a native Edit Connections menu

Open tsimonq2 opened this issue 6 years ago • 17 comments

Right now, we depend on the GNOME network manager to display the "Edit Connections" menu. This is problematic, because at least on Ubuntu and Debian, this pulls in a fair amount of dependencies.

Could we implement this natively?

tsimonq2 avatar Jul 03 '18 19:07 tsimonq2

@tsimonq2 - don't speak for debian here about dependencies - and no, it is not problematic, cmst/connman is the default alternative.

@palinek - but a release would be fine. :)

agaida avatar Jul 03 '18 21:07 agaida

@agaida Are you sure?

nm-tray: starting the nm-connection-editor
$ apt-file find nm-connection-editor
network-manager-gnome: /usr/bin/nm-connection-editor
network-manager-gnome: /usr/share/appdata/nm-connection-editor.appdata.xml
network-manager-gnome: /usr/share/applications/nm-connection-editor.desktop
network-manager-gnome: /usr/share/man/man1/nm-connection-editor.1.gz

Yes, by default, it is using that dialogue.

tsimonq2 avatar Jul 03 '18 21:07 tsimonq2

I am dead sure that we use connman and cmst in debian since the beginning - so - as i wrote, we have no problem. You want nm-tray for Lubuntu and i fully understand it. And i warned you that nm-tray is not prime time ready long ago. One point was the missing native dialogs.

And if this is fixed i would package and upload nm-tray without problems. That does't mean that i would change the defaults too - but it would be fine for network-manager users to have a pure Qt UI alternative.

agaida avatar Jul 03 '18 21:07 agaida

And i warned you that nm-tray is not prime time ready long ago. One point was the missing native dialogs.

Uhm... this is me filing the issue for accomplishing that.

Don't shake your finger at me and say "I told you so." I want to make this project better, and I'm sure you do too, but scolding me for testing it isn't a productive way to do so.

Please, let's keep this on-topic.

tsimonq2 avatar Jul 03 '18 21:07 tsimonq2

Yes, by default, it is using that dialogue.

No, you probably overridden the default, see here -> https://github.com/palinek/nm-tray/blob/master/resources/nm-tray.conf#L2

It is dead sure, that we can have our own connections editor, but I think it would take a lot of time/work and I'm lacking free time to implement it...

palinek avatar Jul 04 '18 08:07 palinek

No, you probably overridden the default

I don't even have that conf file in my packaging. It has not been in a tag yet.

tsimonq2 avatar Jul 04 '18 22:07 tsimonq2

@palinek - but a release would be fine. :)

I don't even have that conf file in my packaging. It has not been in a tag yet.

..released 0.4.0

palinek avatar Jul 05 '18 09:07 palinek

@Myrddin-Wyllt Hi there! Have you worked with GitHub before? I think, it would be nice if you could create a pull request with the mockups, and people could expand on that PR, trying to implement the actual functionalities.

jubalh avatar Nov 17 '18 14:11 jubalh

and there is no functionality written yet. Don't wait on me for the functionality

@Myrddin-Wyllt what is it good for? (to see the possibilities for connection editing we can have a look at nm-connection-editor)

palinek avatar Nov 19 '18 08:11 palinek

@palinek You're right. My mistake. I've deleted my previous comment. Apologies for the intrusion.

Myrddin-Wyllt avatar Nov 25 '18 20:11 Myrddin-Wyllt

No, you probably overridden the default, see here -> https://github.com/palinek/nm-tray/blob/master/resources/nm-tray.conf#L2

Where is that config file loaded in the code? Can't find any reference to it. Can I place it in my home dir to be able to modify it?

cdarken avatar Mar 10 '22 11:03 cdarken

Where is that config file loaded in the code? Can't find any reference to it.

https://github.com/palinek/nm-tray/blob/master/src/tray.cpp#L235 https://github.com/palinek/nm-tray/blob/master/src/tray.cpp#L277 https://github.com/palinek/nm-tray/blob/master/src/tray.cpp#L351

Can I place it in my home dir to be able to modify it?

Yes, you can put it into XDG_CONFIG_HOME. See description of the search paths -> https://doc.qt.io/qt-5/qsettings.html#platform-specific-notes

palinek avatar Mar 10 '22 11:03 palinek

I found those, I was looking for the actual file too. But I understand now it's an automatic config load. Thanks!

cdarken avatar Mar 10 '22 14:03 cdarken

Yes, by default, it is using that dialogue.

No, you probably overridden the default, see here -> https://github.com/palinek/nm-tray/blob/master/resources/nm-tray.conf#L2

It is dead sure, that we can have our own connections editor, but I think it would take a lot of time/work and I'm lacking free time to implement it...

Can you add an option to edit the terminal command to open nmtui-edit? I don't have xterm here and I'd like to use another. I made a symbolic link to /usr/bin/tilix to fix it.

root2185 avatar Aug 07 '23 15:08 root2185

Hello everyone. Do you have any news about this? I'm starting a project about porting LXQt to mobile friendly (discussion here if you are interested. This applet is a good candidate for mobile LXQt being it lightweight and with no GTK dependency.

I would like to fill the gaps, like writing a new Qt UI to replace GNOME Network Editor, thus having full Qt experience. My main goal is to develop a touch friendly interface but I think desktop and mobile UI can live in same executable and maybe switched with a command line argument.

I will do it in my free time so do not expect anything soon, but if you want to collaborate at the code or just send suggestions it's appreciated!

gfgit avatar Dec 13 '23 22:12 gfgit

I would like to fill the gaps, like writing a new Qt UI to replace GNOME Network Editor,

It will be very welcome.

palinek avatar Dec 14 '23 10:12 palinek

xfce4-terminal
Works fine after replacement

marklove5102 avatar Jan 14 '24 07:01 marklove5102