Palo Kisa

> Therefore, qApp->devicePixelRatio() should be avoided, especially here. It is used in Qt for similar purposes also: - https://github.com/qt/qtbase/blob/dev/src/gui/image/qicon.cpp#L175 - https://github.com/qt/qtbase/blob/dev/src/gui/image/qicon.cpp#L854 - https://github.com/qt/qtbase/blob/dev/src/gui/image/qicon.cpp#L896 - https://github.com/qt/qtbase/blob/dev/src/gui/image/qicon.cpp#L914 - https://github.com/qt/qtbase/blob/dev/src/gui/image/qicon.cpp#L943

> One of its windows opens in an ordinary screen. QIcon::pixmap(QWindow *window,...) calls qt_effective_device_pixel_ratio(), sets devicePixelRatio to 1, and then calls d->engine->pixmap(). With your change, it may get a wrong...

> > > ...and we can say the same for the former "HDPI windows" -> without the change the windows on all HDPI screens may get wrong pixmaps (because we...

> Qt6 has gone further and has removed the scaling from QIconEngine::virtual_hook() too. It dropped the whole `virtual_hook` concept, but this doesn't make any difference to our discussed topic here.

> and QIcon::pixmap(QWindow *window,...) has been deprecated. That's a big step further away from consulting qApp's dpr at the level of QIconLoaderEngine. There are still the `QIcon::pixmap(size...)` overloads, which just...

Can you, please, exactly describe icon names, themes etc. for me to replicate it. Maybe we can find a solution/workaround.

What does "symbolic" mean here?

> but Fm::IconInfo doesn't use symbolic icons with a scale factors of 2. It is using what is provided by the icon theme. E.g. the desktop folder -> icon `user-desktop`,...

Oh sorry... missed that. Then the cause is is in `IconEngine::virtual_hook`... I see it now. I have something in my mind, need to test if it can solve this problem.

Please, what icon theme are you using ~and which showed icons are you considering to be shown wrongly~?