react-d3-speedometer icon indicating copy to clipboard operation
react-d3-speedometer copied to clipboard

Display both Segment stops and (inside) labels

Open jacktreg opened this issue 1 year ago • 2 comments

From what I can tell this isn't currently supported. I think this would be useful because both categorical and numerical info indicate different things to users. I'd be happy to open a PR for this if I'm right that this isn't currently supported.

I do understand the thinking behind not showing the segment stops if the segment labels are Outside labels. In this case, the current behavior seems reasonable to me.

jacktreg avatar Dec 12 '24 20:12 jacktreg

It is not supported currently (though I can say it with more confidence if there is an example image). I'm open to a PR and would prefer this under a prop/flag so that existing behaviour is not disrupted, and people can opt to this by using a prop/flag.

palerdot avatar Dec 13 '24 03:12 palerdot

I was able to verify myself this is indeed a limitation. I agree the change should be made to avoid modifying existing behavior. I also decided it shouldn't restrict behavior based on if the labels are Inside or Outside.

The PR is here: https://github.com/palerdot/react-d3-speedometer/pull/193 Let me know what you think when you have a chance!

jacktreg avatar Dec 13 '24 15:12 jacktreg