react-d3-speedometer icon indicating copy to clipboard operation
react-d3-speedometer copied to clipboard

Published 20 hours ago • verified publisher icon palerdot

Fluid Width prop to take only available space

Open yoelbassin opened this issue 2 years ago • 2 comments

Closed #164 since the source branch have changed. Here is the PR rebased from react-v18

yoelbassin avatar Feb 19 '23 05:02 yoelbassin

Thanks, I'm tracking this PR in this issue - https://github.com/palerdot/react-d3-speedometer/issues/166

palerdot avatar Feb 20 '23 03:02 palerdot

@yoelbassin This PR introduces a new prop valueTextBelowPos without being discussed. It would be better if this prop is discussed before making code changes. I'm not also not ok with the prop name valueTextBelowPos, which does not clearly indicate what this does exactly.

There is a whole lot to be done including updating documentation when a new prop is introduced - https://github.com/palerdot/react-d3-speedometer/issues/153

This prop change should be discussed including the name in the issue - https://github.com/palerdot/react-d3-speedometer/issues/166, before I can consider on next steps regarding this PR.

palerdot avatar Feb 23 '23 10:02 palerdot