Phillip Alday
Phillip Alday
@dmbates if you want to take this out of draft, add NEWS (now at `4.10.0`), I think we can go ahead and get this merged.
merge and release when ready!
We can get "overwritten method" warning if somebody loads both packages.
Is the fix as easy as defining ```julia julia> using LinearAlgebra julia> function LinearAlgebra.cholesky!(A::Diagonal{T}, ::RowMaximum; tol=0.0, check::Bool=true) where {T function LinearAlgebra.cholesky(A::Diagonal, ::RowMaximum; tol=0.0, check::Bool=true) A = sqrt.(A) rank = size(A,...
Hmmm, I guess I need to also handle the case where one of the diagonal elements is zero. In that case, I would call `collect(1:rank)` for consistency when there's an...
> Making it an error--for this case which was already buggy--was not a breaking change, since packages had always been told not to call the Core.Compiler functions. @vtjnash I've opened...
@nalimilan what families am I missing? - [x] Normal with identity link - [x] Binomial + Bernoulli - [x] InverseGaussian - [x] Gamma - [x] Poisson - [x] Geometric -...
@mousum-github please don't start making changes on my PR without asking me first.
Sorry, I've been a bit underwater with other priorities. I will start integrating these suggestions -- thanks @mousum-github !