tritium icon indicating copy to clipboard operation
tritium copied to clipboard
verified publisher icon palantir

Header params as tag values

Open ellisjoe opened this issue 8 years ago • 1 comments

Header params are separated by commas (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2) which conflicts with our tagged key/value pair delimiter.

ellisjoe avatar Oct 26 '17 13:10 ellisjoe

Yeah, thinking we might want to use ASCII character codes 29, 30, 31 as separators, or go full structured serDe like Jackson. Thoughts?

Will also add tests for user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36]

schlosna avatar Oct 27 '17 10:10 schlosna