tritium icon indicating copy to clipboard operation
tritium copied to clipboard

Fully enable NullAway:JSpecifyMode checking

Open schlosna opened this issue 2 months ago • 3 comments

Before this PR

We were not using the full JSpecify mode of NullAway and several packages were not fully @NullMarked.

After this PR

==COMMIT_MSG== All tritium packages are fully @NullMarked with jspecify @Nullable or @NonNull annotations as needed by APIs. Enable JSpecify mode for stricter NullAway nullness checking.

See https://github.com/uber/NullAway/wiki/JSpecify-Support and https://github.com/uber/NullAway/wiki/How-NullAway-Works#jspecify ==COMMIT_MSG==

Possible downsides?

schlosna avatar Sep 20 '25 20:09 schlosna

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • [ ] Feature (Adding new functionality)
  • [x] Improvement (Improving existing functionality)
  • [ ] Fix (Fixing an issue with existing functionality)
  • [ ] Break (Creating a new major version by breaking public APIs)
  • [ ] Deprecation (Removing functionality in a non-breaking way)
  • [ ] Migration (Automatically moving data/functionality to a new system)

Description All tritium packages are fully @NullMarked with jspecify @Nullable or @NonNull annotations as needed by APIs. Enable JSpecify mode for stricter NullAway nullness checking.

See https://github.com/uber/NullAway/wiki/JSpecify-Support and https://github.com/uber/NullAway/wiki/How-NullAway-Works#jspecify

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Sep 20 '25 20:09 changelog-app[bot]

Successfully generated changelog entry!

What happened?

Your changelog entries have been stored in the database as part of our migration to ChangelogV3.

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

changelog-app[bot] avatar Sep 20 '25 20:09 changelog-app[bot]

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

stale[bot] avatar Oct 18 '25 05:10 stale[bot]