tracing-java
tracing-java copied to clipboard
Fix JMH benchmarking
Before this PR
./gradlew jmh did not work
After this PR
==COMMIT_MSG==
./gradlew jmh works
==COMMIT_MSG==
Benchmark (observability) Mode Cnt Score Error Units
TracingBenchmark.nestedSpans DO_NOT_SAMPLE avgt 10 494.292 ± 43.218 ns/op
TracingBenchmark.nestedSpans UNDECIDED avgt 10 748.402 ± 36.206 ns/op
TracingBenchmark.nestedSpans SAMPLE avgt 10 30336.603 ± 5844.814 ns/op
TracingBenchmark.traceWithSingleSpan DO_NOT_SAMPLE avgt 10 121.955 ± 18.840 ns/op
TracingBenchmark.traceWithSingleSpan UNDECIDED avgt 10 124.761 ± 18.362 ns/op
TracingBenchmark.traceWithSingleSpan SAMPLE avgt 10 368.724 ± 76.932 ns/op
Possible downsides?
Generate changelog in changelog/@unreleased
changelog/@unreleasedWhat do the change types mean?
feature: A new feature of the service.improvement: An incremental improvement in the functionality or operation of the service.fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.migration: A fully automatic upgrade migration task with no engineer input required.
Note: only one type should be chosen.
How are new versions calculated?
- ❗The
breakandmanual taskchangelog types will result in a major release! - 🐛 The
fixchangelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.
Type
- [ ] Feature
- [ ] Improvement
- [x] Fix
- [ ] Break
- [ ] Deprecation
- [ ] Manual task
- [ ] Migration
Description
./gradlew jmh works
Check the box to generate changelog(s)
- [x] Generate changelog entry