stash-codesearch-plugin icon indicating copy to clipboard operation
stash-codesearch-plugin copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Add support for Bitbucket 4.0.0

Open mithun opened this issue 9 years ago • 10 comments

This PR adds support for Bitbucket Server 4.0.0

Various changes from @terabyte and @gliptak are also merged in.

mithun avatar Oct 15 '15 04:10 mithun

Actually. Scratch that. It only compiles, but doesn't work yet. The soy templates are not rendering. Can someone help fix that? (I have no experience with Atlassian plugin development)

mithun avatar Oct 15 '15 05:10 mithun

I (no longer at palantir) will see what I can do if I get a chance. Typically Palantir doesn't do major version bumps of atlassian stuff until they are on X.1 or X.2, so it could take them a while to get to it.

terabyte avatar Oct 15 '15 16:10 terabyte

@mithun @gliptak Thanks very much for your changes so far - I am testing every change before the bitbucket change in a separate branch which I will push to terabyte/stash-code-search master once I am satisfied. Then I'll take a look at the bitbucket changes and see what I can do there.

terabyte avatar Oct 15 '15 19:10 terabyte

@terabyte Sounds good. Thanks.

mithun avatar Oct 15 '15 21:10 mithun

Ok, everything is in except for the bitbucket 4.0.0 commit. I am taking a look now.

terabyte avatar Oct 15 '15 21:10 terabyte

Will https://github.com/terabyte/stash-codesearch-plugin become the new official repo? @terabyte Are you planning to publish to Atlassian plugin repo (preferably both 3.x and 4.x versions)? Thanks

gliptak avatar Oct 15 '15 21:10 gliptak

I don't know the answer to those questions yet. If Palantir is willing to support this thing and keep it up to date I see no reason to fork, but if there isn't resources to do that, better that someone does it.

Thanks to the wonder of DVCS, it suffices to say right now that there is no "official" repo, just the palantir version and the terabyte version. Whether or not I upload my versions to the marketplace will again depend upon palantir's willingness to do so. I worry if I go full hog and fork needlessly I'm potentially just making more work for myself, because they could ask me to change the plugin key and logos (maybe? unsure about the legalities there).

terabyte avatar Oct 16 '15 00:10 terabyte

Almost have it working, but not quite: https://github.com/terabyte/stash-codesearch-plugin/tree/feature/bitbucket-4.0

The search works, but the servlets aren't rendering quite right yet.

terabyte avatar Oct 17 '15 00:10 terabyte

@terabyte I just tried https://github.com/terabyte/stash-codesearch-plugin/releases/tag/2.0.0 and it works for me. Thanks for helping out.

mithun avatar Oct 23 '15 21:10 mithun

awesome! no problemo, glad to help out!

terabyte avatar Oct 23 '15 22:10 terabyte