stacktrace icon indicating copy to clipboard operation
stacktrace copied to clipboard

Add unwrap support

Open vosst opened this issue 5 years ago • 9 comments

This change adds support for errors.Unwrap functionality originally introduced in Golang 1.13. While the library code does not need to take multiple Golang versions into account, the testing code needs to distinguish the cases Golang < 1.13 and Golang >= 1.13. For that, I introduced an unwrap helper with different implementation depending on the Golang version.

vosst avatar Aug 27 '20 12:08 vosst

Thanks for your interest in palantir/stacktrace, @vosst! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Aug 27 '20 12:08 palantirtech

@nmiyake I tried to sign the CLA using cla.palantir.com but only realized when looking at the DocuSign request that my primary email address on my github profile isn't my personal one. Could you help in resetting the cla.palantir.com entry for my github username such that I can sign the CLA for my personal email address? Thanks 😄

vosst avatar Aug 27 '20 12:08 vosst

@dtolnay ^ because I see you on the list of contributors, too.

vosst avatar Aug 27 '20 12:08 vosst

Hey @vosst sorry about that, can you try again now?

asvoboda avatar Aug 27 '20 13:08 asvoboda

@asvoboda thanks for the swift response, signed the CLA.

vosst avatar Aug 27 '20 14:08 vosst

@asvoboda can you help out with reviewing/finding reviewers here, too?

vosst avatar Aug 28 '20 09:08 vosst

Yep, I've pinged some of our internal folks to take a look. This repo looks like it needs a bit of TLC first

asvoboda avatar Aug 28 '20 10:08 asvoboda

@asvoboda happy to help out, too. Let me know if there are any tasks that I can assist with.

vosst avatar Aug 28 '20 13:08 vosst

@asvoboda we switched to a project-specific fork for the time being (see https://github.com/interuss/dss/pull/426/files). Would be great to get the functionality upstream, though.

vosst avatar Aug 31 '20 07:08 vosst