sls-packaging icon indicating copy to clipboard operation
sls-packaging copied to clipboard

JDK9 Support: Remove deleted GC flags

Open ash211 opened this issue 8 years ago • 1 comments

Compare these two links:

  • "Options That Won’t Work " section of https://www.azul.com/jdk-9-pitfalls-for-the-unwary/
  • args we set at https://github.com/palantir/sls-packaging/blob/2.4.0/gradle-sls-packaging/src/main/groovy/com/palantir/gradle/dist/service/tasks/LaunchConfigTask.groovy#L34

We might need to remove:

  • PrintGCDateStamps
  • UseGCLogFileRotation
  • GCLogFileSize
  • NumberOfGCLogFiles

Possibly there are others as well, looking at JEP 214 on that page.

cc @schlosna

ash211 avatar Jul 11 '17 23:07 ash211

Yeah, I expect that we need to allow selection of Java 8 or 9, and derive appropriate default flags for each. We'll likely need to enable the module escape valves for a bit.

schlosna avatar Jul 12 '17 00:07 schlosna