Permit -dev tags for sls-asset-distribution development

[pearsonhenri]

For products that manually tag the version they're devving on as x.x.x-dev, when trying to build the dist with sls-asset-distribution 2.0.0, createManifest failes due to Version string in project contour-app is not orderable as per SLS specification: 2.1.0-dev-21-ge5e4485.

Could I throw up a PR adding a (-dev)? matching group in https://github.com/palantir/sls-packaging/blob/develop/sls-versions/src/main/java/com/palantir/slspackaging/versions/SlsProductVersions.java#L11?

[uschi2000]

The versioning ordering scheme we settled on discourages -dev tags, so I don't see why this is needed.

On Tue, Mar 7, 2017 at 11:52 AM Pearson Henri [email protected] wrote:

For products that manually tag the version they're devving on as x.x.x-dev, when trying to build the dist with sls-asset-distribution 2.0.0, createManifest failes due to Version string in project contour-app is not orderable as per SLS specification: 2.1.0-dev-21-ge5e4485.

Could I throw up a PR adding a (-dev)? matching group in https://github.com/palantir/sls-packaging/blob/develop/sls-versions/src/main/java/com/palantir/slspackaging/versions/SlsProductVersions.java#L11 ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/palantir/sls-packaging/issues/198, or mute the thread https://github.com/notifications/unsubscribe-auth/AGOdwQVA80fuZhye9sKA8WPNjwTTCT2Yks5rjYsmgaJpZM4MVvWw .

[pearsonhenri]

We've found it preferable to manually tag our repository with x.y.(z+1)-dev after cutting an x.y.z release branch (since the tag doesn't actually get applied to the branch until release and snapshots won't be published with that tag until it's merged back into develop), so this is a problem for any of our non-release builds.

[markelliot]

We'd prefer you update your process rather than changing the way this plugin functions, I think.