python-jsonrpc-server icon indicating copy to clipboard operation
python-jsonrpc-server copied to clipboard
verified publisher icon palantir

PR: Migrate package to use asyncio, remove Python 2.7 support

Open andfoy opened this issue 5 years ago • 11 comments

This PR enables this package to use asyncio constructs by default, all the functions were migrated to use async/await syntax and ThreadPoolExecutor was removed and replaced by asyncio.tasks

andfoy avatar May 22 '20 01:05 andfoy

@andfoy

You beat me to it! If you catch any grief over the breaking change, it might be worth considering an alternate layout with all the asyncio analogs couched in a subpackage. Hope this PR gains some traction.

poppyschmo avatar Jun 30 '20 07:06 poppyschmo

Hi @poppyschmo, thanks for your input on this one, right now we're stuck until @ccordoba12 obtains write permissions on this repo

andfoy avatar Jul 09 '20 22:07 andfoy

@uschi2000, I forgot to mention we have here the same problem we had on python-language-server. So could you remove the Required checks on this repo so we can migrate our tests to Github Actions?

ccordoba12 avatar Aug 04 '20 17:08 ccordoba12

Pinging @uschi2000 about this one again. Sorry to bother you again, please see my comment above. That's the last blocker before we can move to Python 3 and better maintain this project.

ccordoba12 avatar Aug 07 '20 15:08 ccordoba12

@delta003 @jroitgrund could you please take care of the python-language-server CI setup, please?

uschi2000 avatar Aug 07 '20 17:08 uschi2000

@ccordoba12 Removed required

delta003 avatar Aug 09 '20 20:08 delta003

@delta003, thanks a lot for your help!

ccordoba12 avatar Aug 10 '20 01:08 ccordoba12

@andfoy I can't push to your fork to fix these tests, it should be quick, can you fix it?

delta003 avatar Sep 08 '20 09:09 delta003

Hi @delta003, this PR brakes compatibility with the python-language-server, since we don't have a PR ready there. I don't know what @ccordoba12 thinks about creating a release as the last version that supports python 2.7 and include this one on the next one

andfoy avatar Sep 08 '20 16:09 andfoy

I agree. We need to leave this one open until a PR that uses asyncio is ready on python-language-server.

ccordoba12 avatar Sep 12 '20 03:09 ccordoba12

FYI: asyncio was introduced in v3.4 so this will not only break compatibility with PY2 by also <3.4.

rchl avatar Sep 12 '20 20:09 rchl