plottable icon indicating copy to clipboard operation
plottable copied to clipboard

Plot._onDatasetUpdate() name misleading

Open aicioara opened this issue 10 years ago • 0 comments

protected _onDatasetUpdate() {
  this._updateExtents();
  this._dataChanged = true;
  this.render();
}

Is misleading. Generally methods starting with on are setting a callback, like in

    public onMouseDown(callback: MouseCallback) {
      this._setCallback(this._downCallbacks, callback);
      return this;
    }

While this is clearly a dispatcher.

Method should be deprecated, renamed to _dispatchDatasetUpdate() and removed in v2.0.0

aicioara avatar Aug 18 '15 19:08 aicioara