palantir-java-format icon indicating copy to clipboard operation
palantir-java-format copied to clipboard

Allow selecting code style in Intellij plugin

Open shitikanth opened this issue 9 months ago • 6 comments

Before this PR

Idea plugin users could not choose the code style (GOOGLE, PALANTIR vs AOSP) although this was allowed using the cli as well as the maven and gradle plugins.

After this PR

The plugin allows users to select between the three supported code styles.

Closes #903

Possible downsides?

None that I can think of.

shitikanth avatar Mar 27 '25 05:03 shitikanth

Thanks for your interest in palantir/palantir-java-format, @shitikanth! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Mar 27 '25 05:03 palantirtech

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • [ ] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Allow selecting code style in Intellij plugin

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar Mar 27 '25 05:03 changelog-app[bot]

Any update on this? Not sure what the hold up is for such basic yet useful feature.

q3769-patientpoint avatar Aug 02 '25 15:08 q3769-patientpoint

@q3769-patientpoint Very few non-bot commits in the project in the past three months. Looks like not a very big priority within Palantir. 🤷

shitikanth avatar Aug 26 '25 08:08 shitikanth

@q3769-patientpoint Very few non-bot commits in the project in the past three months. Looks like not a very big priority within Palantir. 🤷

Did you sign the contributor license agreement as requested?

q3769-patientpoint avatar Aug 26 '25 19:08 q3769-patientpoint

Did you sign the contributor license agreement as requested?

Yup, signed on the same day I submitted the PR. Just waiting for a reviewer to approve afaict.

shitikanth avatar Aug 26 '25 21:08 shitikanth