gradle-shadow-jar icon indicating copy to clipboard operation
gradle-shadow-jar copied to clipboard

Support for product-dependencies (pdeps) embedded in jar manifests

Open iamdanfox opened this issue 4 years ago • 2 comments

I'm pretty sure if you have a classpath which contains a few jars, each with their own 'product-dependency' info embedded in their manifest, applying the shadow-jar plugin won't correctly preserve this info

iamdanfox avatar Nov 30 '20 22:11 iamdanfox

I noticed that when I run the publish task on atlasdb proxy I get

  - Variant shadowRuntimeElements:
      -  contains dependencies that cannot be represented in a published pom file.
          - my-product:1.76.1-1-g2412483 declared with Gradle attributes

jeremyk-91 avatar Dec 01 '20 19:12 jeremyk-91

I think the bug is valid, but that particular warning you're seeing is actually something different (and harmless) - there's a concept of gradle 'attributes' which the plugin uses internally, and effectively get thrown away when you publish to a normal maven repo with a pom. Gradle invented their own replacement for pom files called .module files which can represent these fancy attributes, but we've chosen to turn them off because they didn't play nicely with GCV (and also keep life simple)

iamdanfox avatar Dec 01 '20 21:12 iamdanfox