gradle-graal icon indicating copy to clipboard operation
gradle-graal copied to clipboard

Support for Kotlin Multiplatform

Open yschimke opened this issue 3 years ago • 2 comments

Before this PR

See https://github.com/palantir/gradle-graal/issues/129

Plugins with kotlin("multiplatform") don't have jar or runtimeClasspath.

Gradle don't consider this a bug https://github.com/gradle/gradle/issues/19449, because different project types like jvm, multiplatform, spring-boot should all be supported by plugins such as this.

There are two workarounds I needed to get this working

https://github.com/square/okhttp/blob/master/okcurl/build.gradle.kts#L59

https://github.com/square/okhttp/blob/master/okcurl/build.gradle.kts#L104

After this PR

==COMMIT_MSG== Support Kotlin Multiplatform projects. ==COMMIT_MSG==

Possible downsides?

The approach suggested in https://github.com/gradle/gradle/issues/19449 is to push this onto developers, so it might be a cleaner solution to make these elements configurable.

yschimke avatar Aug 15 '22 14:08 yschimke

Thanks for your interest in palantir/gradle-graal, @yschimke! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Aug 15 '22 14:08 palantirtech

Generate changelog in changelog/@unreleased

Type See change types. Select one:

  • [ ] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Support Kotlin Multiplatform projects.

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar Aug 15 '22 14:08 changelog-app[bot]