gradle-baseline

gradle-baseline copied to clipboard

## What happened? Opening [palantir/assertj-automation](https://github.com/palantir/assertj-automation) in IntelliJ 2019.2 results in failed compilation saying "Invalid target release 11" even though sourceCompatibility = 1.8 is set. ## What did you want to...

iamdanfox

Forbid unbounded waiting on Futures/Latches etc.

1

What did you want to happen? * Latch#await() -> Latch#await(duration) * Future#get() -> Future#get(duration) * etc.

gatesn

## What happened? A bunch of different projects have reported occasional failures of the form: ``` > Task :sls-elasticsearch-sidecar:checkClassUniqueness FAILED Failed to read JarFile sls-elasticsearch-sidecar-shared.jar (project :sls-elasticsearch-sidecar-shared) java.util.zip.ZipException: invalid entry...

iamdanfox

See https://errorprone.info/bugpattern/ExtendsAutoValue code: https://github.com/google/error-prone/blob/master/core/src/main/java/com/google/errorprone/bugpatterns/ExtendsAutoValue.java ## What happened? The same justification applies to immutables, but it would be helpful to provide a check at build time. I've fixed bugs caused by...

carterkozak

Fix #1043: Interruption handling check

4

Fix #1043 Currently using the ExceptionSpecificity base branch to avoid duplicating utility functionality. ==COMMIT_MSG== error prone `HandleInterruption` to ensure users who catch InterruptedException also call `Thread.currentThread().interrupt()`. ==COMMIT_MSG==

carterkozak

[format] FR: Rewrite ImmutableMap.of() as ImmutableMap.builder()....build()

2

## What happened? `baseline-format` rewrote ``` ImmutableMap.of( "A", 1, "B", 2, "C", 3); ``` as ``` ImmutableMap.of( "A", 1, "B", 2, "C", 3); ``` which is significantly less readable. ##...

henryptung

Consider allowing other.addSuppressed(t) for ThrowSpecificity check

3

## What happened? Write code like the following: ``` try { // ... } catch (IOException e) { try { // do cleanup } catch (Throwable t) { e.addSuppressed(t); }...

henryptung

## What happened? Baseline pre [2.38.0](https://github.com/palantir/gradle-baseline/releases/tag/2.38.0) is compiled and tested with error-prone 2.3.3. If a project using one of these older baseline versions finds error_prone_annotations 2.3.4 on their compile classpath,...

iamdanfox

## What happened? Currently, it is possible for products to accumulate entirely unused classes without any kind of static analysis failing. This recently caused a false positive when we are...

iamdanfox

[do not merge] Migrate WebApplicationExceptions to ServiceException

2

Is gradle-baseline the right place for this type of check? It would be dangerous to recommend making this migration on all projects, as it would be problematic for any project...

carterkozak