gradle-baseline

gradle-baseline copied to clipboard

checkUnusedDependencies flake

1

## What happened? A [tritium develop build failed](https://app.circleci.com/pipelines/github/palantir/tritium/720/workflows/dd8ac7e6-159a-4ff5-9152-1cc2cfecf91c/jobs/10237) for https://github.com/palantir/tritium/pull/848 after merging the bump for `com.palantir.baseline:gradle-baseline-java` from `3.37.1` to `3.38.0`. The error message below and linked above poses a quite...

schlosna

Error prone should enforce @Value.Default on defaults in install configurations

3

## What happened? Omitting `@Value.Default` on a method with `default` in an install config interface will compile but will fail if that field is ever set, e.g. ``` @JsonProperty("blah") default...

Jolyon-S

com.palantir.baseline-idea should set up groovy test source dirs correctly

4

## What happened? The following snippet is copied and pasted in lots of internal projects: ```gradle idea { module { testSourceDirs += file("src/test/groovy") } } ``` ## What did you...

iamdanfox

## What happened? A variable that was annotated with junit's `@RegisterExtension` was reported as unused, but the presence of the variable with that annotation has side-effects so it shouldn't be...

jackwickham

## What happened? We had a few `SuppressWarnings` which were previously required but became unnecessary at some point. ## What did you want to happen? It would be great if...

a-k-g

Support record types

2

## What happened? When using record types, I hit the following issues: - Misfiring `StrictUnusedVariable`: ``` Foo.java:43: error: [StrictUnusedVariable] The parameter 'a' is never read. record Foo(int a, int b)...

raiju

## What happened? When using code of the shape `foo instance String myString`, both checkstyle & spotless fail. Checkstyle: ``` [ant:checkstyle] Foo.java:70:50: unexpected token: foo ``` Spotless: ``` ... Caused...

raiju

Automated refactoring for Optional.orElse case is too aggressive

1

At present, _no_ method calls are really allowed in Optional.orElse. This means that code like ```java maybeSet.orElse(emptySet()); // method call is optimized away to a constant ``` will get refactored...

j-baker

The com.palantir.common.streams.KeyedStream is commonly used, but a better alternative (suggested in the KeyedStream repo) is `EntryStream`. ## What did you want to happen? Would be great to have a refaster/error-prone...

Dgleish

Rewriting lambdas to method references can produce ambiguous code that doesn't compile

1

## What happened? If a method has two overloads, one for `Function` and one for `BiFunction`, it's possible for the rule to rewrite lambdas to produce ambiguous code. `x ->...

jackwickham