gradle-baseline icon indicating copy to clipboard operation
gradle-baseline copied to clipboard

Simplify error-prone refactoring code

Open CRogers opened this issue 1 year ago • 1 comments

Before this PR

Now we've upgraded to recent errorprone, there are some workarounds we had for bugs that are no longer necessary. Now that https://github.com/google/error-prone/issues/3908 is fixed (and released in 2.26.0) we can avoid explicitly disabling checks when patching.

After this PR

==COMMIT_MSG== Simplify error-prone refactoring code ==COMMIT_MSG==

Possible downsides?

CRogers avatar Aug 20 '24 13:08 CRogers

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • [ ] Feature
  • [ ] Improvement
  • [x] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Simplify error-prone refactoring code

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Aug 20 '24 13:08 changelog-app[bot]