gradle-baseline icon indicating copy to clipboard operation
gradle-baseline copied to clipboard

Make checkJavaVersions task more amenable to gradle8 configuration cache

Open ash211 opened this issue 11 months ago • 1 comments

Addresses https://github.com/palantir/gradle-baseline/issues/1719

Before this PR

The checkJavaVersions task directly accessed the project during execution, which is flagged in the configuration cache report:

Screenshot 2024-03-06 at 10 28 50 PM

Looking at the gradle docs here, the recommendation is to use a Property<String> instead of accessing the Project directly.

After this PR

==COMMIT_MSG== Make checkJavaVersions task more amenable to gradle8 configuration cache ==COMMIT_MSG==

Possible downsides?

I don't really know what I'm doing.

ash211 avatar Mar 07 '24 06:03 ash211

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • [ ] Feature
  • [ ] Improvement
  • [x] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Make checkJavaVersions task more amenable to gradle8 configuration cache

Check the box to generate changelog(s)

  • [x] Generate changelog entry

changelog-app[bot] avatar Mar 07 '24 06:03 changelog-app[bot]