gradle-baseline icon indicating copy to clipboard operation
gradle-baseline copied to clipboard

`StrictUnusedVariable`: update severity to a warning, and remove suggested fixes to prefix variables with underscores

Open mpritham opened this issue 1 year ago • 1 comments

Before this PR

The StrictUnusedVariable check currently produces errors when a variable is unused unless it is prefixed with an underscore. There are cases (albeit rare) where users legitimately need to keep a reference to an object in scope to prevent the GC from cleaning it. For these scenarios, the underscore prefix (or a suppression) is introduced to satisfy this check.

By moving the severity to the WARNING level, users will still be alerted of their unused variables, and can decide what action they'd like to take.

After this PR

==COMMIT_MSG== Closes #2361. Change the severity to WARNING. Remove suggested fixes to prefix unused variables with underscores, but keep the suggested fix which renames used variables prefixed with underscores. ==COMMIT_MSG==

Possible downsides?

mpritham avatar Jun 14 '23 19:06 mpritham

Generate changelog in changelog/@unreleased

Type

  • [ ] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Closes #2361. Change the severity to WARNING. Remove suggested fixes to prefix unused variables with underscores, but keep the suggested fix which renames used variables prefixed with underscores.

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar Jun 14 '23 19:06 changelog-app[bot]