go-license icon indicating copy to clipboard operation
go-license copied to clipboard

Problem: go-license fails with example config

Open yrashk opened this issue 4 years ago • 2 comments

When used with a config similar to the one in README, go-license fails with:

Error: failed to read file .license.yml: failed to unmarshal license-plugin v0 configuration: yaml: unmarshal errors:
  line 12: field exclude-names not found in type matcher.NamesPathsCfg

Solution: change exclude-names to names as this is how it is

Before this PR

Failure when trying it out according to the example provided

After this PR

No failure.

Possible downsides?

None?

yrashk avatar May 13 '21 18:05 yrashk

Thanks for your interest in palantir/go-license, @yrashk! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar May 13 '21 18:05 palantirtech

Generate changelog in changelog/@unreleased

Type

  • [ ] Feature
  • [X] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Problem: go-license fails with example config

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar May 13 '21 18:05 changelog-app[bot]