docker-compose-rule icon indicating copy to clipboard operation
docker-compose-rule copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Fix parsing of docker-compose < 1.25.2 output on narrow terminals

Open albanf opened this issue 3 years ago • 2 comments

Before this PR

Issue described https://github.com/palantir/docker-compose-rule/issues/411

Fixed for docker-machine in https://github.com/palantir/docker-compose-rule/pull/424, but it's easy to forget to set the COLUMNS in other contexts.

We cannot upgrade to docker-compose 1.25.2+ for various reasons, so this workaround is useful.

After this PR

==COMMIT_MSG== Works around ps output of docker-compose before 1.25.2 which adjust their output based on the width of the terminal. ==COMMIT_MSG==

Possible downsides?

albanf avatar Dec 02 '22 08:12 albanf

Thanks for your interest in palantir/docker-compose-rule, @albanf! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

palantirtech avatar Dec 02 '22 08:12 palantirtech

Generate changelog in changelog/@unreleased

Type

  • [ ] Feature
  • [ ] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Works around ps output of docker-compose before 1.25.2 which adjust their output based on the width of the terminal.

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar Dec 02 '22 08:12 changelog-app[bot]