docker-compose-rule icon indicating copy to clipboard operation
docker-compose-rule copied to clipboard
verified publisher icon palantir

Added Windows default paths for docker.exe and docker-compose.exe

Open tifoha opened this issue 6 years ago • 3 comments

Before this PR

this docker-compose-rule not working out of the box with windows machines, cause there are no default path to docker executables

After this PR

now it should work with windows

Possible downsides?

didn't find any downsides

tifoha avatar Aug 07 '19 13:08 tifoha

Generate changelog in changelog/@unreleased

Type

  • [ ] Feature
  • [X] Improvement
  • [ ] Fix
  • [ ] Break
  • [ ] Deprecation
  • [ ] Manual task
  • [ ] Migration

Description Added Windows default paths for docker.exe and docker-compose.exe

Before this PR

this docker-compose-rule not working out of the box with windows machines, cause there are no default path to docker executables

After this PR

now it should work with windows

Possible downsides?

didn't find any downsides

Check the box to generate changelog(s)

  • [ ] Generate changelog entry

changelog-app[bot] avatar Aug 07 '19 13:08 changelog-app[bot]

@tifoha thanks for the contribution! There was a flake in the build that was resolved by https://github.com/palantir/docker-compose-rule/pull/320, you'll want to rebase your branch to pick up the fix

ferozco avatar Aug 22 '19 13:08 ferozco

I merged changes upstream into my fork. Also I fixed warnings from gradle about using Guava Concurent hash set instead of standard JDK. @ferozco Can you review my changes?

tifoha avatar Sep 04 '19 23:09 tifoha