docker-compose-rule icon indicating copy to clipboard operation
docker-compose-rule copied to clipboard
verified publisher icon palantir

Re-enable ShutdownStrategy access to running rule

Open m4ksio opened this issue 8 years ago • 2 comments

I noticed that as a part of https://github.com/palantir/docker-compose-rule/pull/140 the parameters of ShutdownStrategy.shutdown() changed from single DockerDomposeRule params to two separate DockerCompose and Docker ones. I understand it's to remove cross-dependency between -core and -junit4 projects, but this strips down the important functionality of being able to access the configuration of cluster being shut down, which comes in handy.

We used it to create, i.e. our own ShutdownStrategy which copied some additional metrics before killing the containers.

m4ksio avatar Mar 16 '17 17:03 m4ksio

Hey @m4kspl,

That makes sense. What kind of metrics were you pulling out? We've probably just not got the right components being passed through to shutdown right now. e.g. passing shutdown the Cluster being shutdown would entirely make sense. Would this solve your problem?

joelea avatar Mar 21 '17 11:03 joelea

@m4ksio - wondering if this is still an issue for you.

fryz avatar Apr 30 '18 21:04 fryz