conjure icon indicating copy to clipboard operation
conjure copied to clipboard

Consistent name enforcement for param id

Open ferozco opened this issue 7 years ago • 4 comments

Currently we allow fields names to be non-camel case for ease of migration. We however enforce that endpoint parameters must be camelCase.

We should be consistent and permissive and allow parameters to also be non-camel case

ferozco avatar Jul 24 '18 14:07 ferozco

Are there any plans to fix this issue? I just ran into this when I went to conjurify the Datadog API and they use snake_case for their query param-id (api_key)

tabboud avatar Apr 26 '19 03:04 tabboud

Haven't had the time to look into this, but would happily accept a PR

ferozco avatar Apr 26 '19 18:04 ferozco

Fixed by #299

bmoylan avatar May 06 '19 23:05 bmoylan

Conjurifying non-Conjure APIs is a non-goal for Conjure. I'd very much like to move away from all the limbo states where things are sort of allowed but also sort of not in Conjure definitions. In this case: if there's a real reason for preferring camelCase, then we should work towards removing the limbo and migrating APIs towards camelCase. Conversely, if there isn't a real reason, then we can just remove the strict checks and warnings and say that everything can cased as it likes.

uschi2000 avatar May 07 '19 06:05 uschi2000